ENH: allow layout for grouped DataFrame histograms #4104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@jreback any comments b4 i merge? nothing drastic here just supporting the new layout argument with the by argument |
|
oh release notes |
| @@ -314,6 +314,8 @@ pandas 0.12 | |||
| - Fix bug where ``HDFStore`` will fail to append because of a different block | |||
| ordering on-disk (:issue:`4096`) | |||
| - Better error messages on inserting incompatible columns to a frame (:issue:`4107`) | |||
| - The ``by`` argument now works correctly with the ``layout`` argument | |||
There was a problem hiding this comment.
maybe add in plot.hist here....so it has some context
|
i think this could be merged once it passes...nothing super drastic, just allows the layout keyword to work when the by keyword is passed |
|
eh i'll wait...not critical |
|
@jreback shoudl this be marked for 0.12 to close the kde plot issue? or i can mark that one for 0.13...even though it is probably fixed, if we do 0.12.1 it could go there instead as a bug fix along with this... |
|
up2u |
1 similar comment
|
up2u |
|
k i'll mark #4194 for 0.13/0.12.1, just want to get those html bugs squashed! |
|
@jreback anything to add here b4 i merge? |
|
ok |
Also remove the slow decorator for tests that take < 100 ms time
cpcloud
added a commit
that referenced
this pull request
Jul 25, 2013
ENH: allow layout for grouped DataFrame histograms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the slow decorator for tests that take < 100 ms time
closes #4102.
closes #4194.